diff options
| author | Johan Hovold <johan@kernel.org> | 2015-05-04 17:10:28 +0200 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2015-05-12 10:46:31 +0200 |
| commit | 52176d0d3be29ccb01a44ee77532bb3969939ecf (patch) | |
| tree | c9ba29e8f5031f40a50254b012a9c176c6d71a2b /drivers/parisc/iosapic_private.h | |
| parent | gpio: clean up gpiochip_remove (diff) | |
| download | linux-52176d0d3be29ccb01a44ee77532bb3969939ecf.tar.xz linux-52176d0d3be29ccb01a44ee77532bb3969939ecf.zip | |
gpio: sysfs: fix redundant lock-as-irq handling
Drivers should call gpiochip_lock_as_irq (which prevents the pin
direction from being changed) in their irq_request_resources callbacks
but some drivers currently fail to do so.
Instead a second, explicit and often redundant call to lock-as-irq is
made by the sysfs-interface implementation after an irq has been
requested.
Move the explicit call before the irq-request to match the unlock done
after the irq is later released. Note that this also fixes an irq leak,
should the explicit call ever have failed.
Also add a comment about removing the redundant call once the broken
drivers have been fixed.
Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/parisc/iosapic_private.h')
0 files changed, 0 insertions, 0 deletions