diff options
| author | Julia Lawall <Julia.Lawall@lip6.fr> | 2012-11-03 11:58:36 +0100 |
|---|---|---|
| committer | Helge Deller <deller@gmx.de> | 2013-02-20 22:49:07 +0100 |
| commit | 93c3e913e104c9277e32a0d7e03f268d146c57ee (patch) | |
| tree | 06201c54ff564d4afe4458857dddcf2886adfc57 /drivers/parisc | |
| parent | drivers/parisc: Use printf extension %pR for struct resource (diff) | |
| download | linux-93c3e913e104c9277e32a0d7e03f268d146c57ee.tar.xz linux-93c3e913e104c9277e32a0d7e03f268d146c57ee.zip | |
drivers/parisc/pdc_stable.c: use WARN
Use WARN rather than printk followed by WARN_ON(1), for conciseness.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Helge Deller <deller@gmx.de>
Diffstat (limited to 'drivers/parisc')
| -rw-r--r-- | drivers/parisc/pdc_stable.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/parisc/pdc_stable.c b/drivers/parisc/pdc_stable.c index 246a92f677e4..0f54ab6260df 100644 --- a/drivers/parisc/pdc_stable.c +++ b/drivers/parisc/pdc_stable.c @@ -212,12 +212,10 @@ pdcspath_store(struct pdcspath_entry *entry) entry, devpath, entry->addr); /* addr, devpath and count must be word aligned */ - if (pdc_stable_write(entry->addr, devpath, sizeof(*devpath)) != PDC_OK) { - printk(KERN_ERR "%s: an error occurred when writing to PDC.\n" + if (pdc_stable_write(entry->addr, devpath, sizeof(*devpath)) != PDC_OK) + WARN(1, KERN_ERR "%s: an error occurred when writing to PDC.\n" "It is likely that the Stable Storage data has been corrupted.\n" "Please check it carefully upon next reboot.\n", __func__); - WARN_ON(1); - } /* kobject is already registered */ entry->ready = 2; |