summaryrefslogtreecommitdiffstats
path: root/drivers/pci/controller/dwc/pcie-armada8k.c
diff options
context:
space:
mode:
authorThierry Reding <treding@nvidia.com>2019-08-29 12:53:17 +0200
committerLorenzo Pieralisi <lorenzo.pieralisi@arm.com>2019-09-04 16:42:38 +0200
commite7a877b2fa79c57c3eac7d28803279a356844907 (patch)
tree148da26bc2f9d4d44338b5b63e0abe79f97e4a6b /drivers/pci/controller/dwc/pcie-armada8k.c
parentPCI: imx6: Propagate errors for optional regulators (diff)
downloadlinux-e7a877b2fa79c57c3eac7d28803279a356844907.tar.xz
linux-e7a877b2fa79c57c3eac7d28803279a356844907.zip
PCI: armada8x: Propagate errors for optional PHYs
devm_of_phy_get_by_index() can fail for a number of reasons besides probe deferral. It can for example return -ENOMEM if it runs out of memory as it tries to allocate devres structures. Propagating only -EPROBE_DEFER is problematic because it results in these legitimately fatal errors being treated as "PHY not specified in DT". What we really want is to ignore the optional PHYs only if they have not been specified in DT. devm_of_phy_get_by_index() returns -ENODEV in this case, so that's the special case that we need to handle. So we propagate all errors, except -ENODEV, so that real failures will still cause the driver to fail probe. Signed-off-by: Thierry Reding <treding@nvidia.com> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Reviewed-by: Andrew Murray <andrew.murray@arm.com> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Diffstat (limited to 'drivers/pci/controller/dwc/pcie-armada8k.c')
-rw-r--r--drivers/pci/controller/dwc/pcie-armada8k.c7
1 files changed, 3 insertions, 4 deletions
diff --git a/drivers/pci/controller/dwc/pcie-armada8k.c b/drivers/pci/controller/dwc/pcie-armada8k.c
index 3d55dc78d999..49596547e8c2 100644
--- a/drivers/pci/controller/dwc/pcie-armada8k.c
+++ b/drivers/pci/controller/dwc/pcie-armada8k.c
@@ -118,11 +118,10 @@ static int armada8k_pcie_setup_phys(struct armada8k_pcie *pcie)
for (i = 0; i < ARMADA8K_PCIE_MAX_LANES; i++) {
pcie->phy[i] = devm_of_phy_get_by_index(dev, node, i);
- if (IS_ERR(pcie->phy[i]) &&
- (PTR_ERR(pcie->phy[i]) == -EPROBE_DEFER))
- return PTR_ERR(pcie->phy[i]);
-
if (IS_ERR(pcie->phy[i])) {
+ if (PTR_ERR(pcie->phy[i]) != -ENODEV)
+ return PTR_ERR(pcie->phy[i]);
+
pcie->phy[i] = NULL;
continue;
}