diff options
| author | Vishal Aslot <os.vaslot@gmail.com> | 2021-08-18 18:57:51 +0200 |
|---|---|---|
| committer | Bjorn Helgaas <bhelgaas@google.com> | 2021-09-02 19:02:50 +0200 |
| commit | faa2e05ad0dccf37f995bcfbb8d1980d66c02c11 (patch) | |
| tree | baeb98790707575a74a1b13f9eb761504174827b /drivers/pci/hotplug/TODO | |
| parent | Linux 5.14-rc1 (diff) | |
| download | linux-faa2e05ad0dccf37f995bcfbb8d1980d66c02c11.tar.xz linux-faa2e05ad0dccf37f995bcfbb8d1980d66c02c11.zip | |
PCI: ibmphp: Fix double unmap of io_mem
ebda_rsrc_controller() calls iounmap(io_mem) on the error path. Its caller,
ibmphp_access_ebda(), also calls iounmap(io_mem) on good and error paths.
Remove the iounmap(io_mem) invocation from ebda_rsrc_controller().
[bhelgaas: remove item from TODO]
Link: https://lore.kernel.org/r/20210818165751.591185-1-os.vaslot@gmail.com
Signed-off-by: Vishal Aslot <os.vaslot@gmail.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Diffstat (limited to 'drivers/pci/hotplug/TODO')
| -rw-r--r-- | drivers/pci/hotplug/TODO | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/pci/hotplug/TODO b/drivers/pci/hotplug/TODO index a32070be5adf..cc6194aa24c1 100644 --- a/drivers/pci/hotplug/TODO +++ b/drivers/pci/hotplug/TODO @@ -40,9 +40,6 @@ ibmphp: * The return value of pci_hp_register() is not checked. -* iounmap(io_mem) is called in the error path of ebda_rsrc_controller() - and once more in the error path of its caller ibmphp_access_ebda(). - * The various slot data structures are difficult to follow and need to be simplified. A lot of functions are too large and too complex, they need to be broken up into smaller, manageable pieces. Negative examples are |