diff options
| author | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-01-23 21:01:12 +0100 |
|---|---|---|
| committer | Bjorn Helgaas <bhelgaas@google.com> | 2014-02-04 07:08:48 +0100 |
| commit | 13f81c099bee8141f764fd41a1f4b68b93be3296 (patch) | |
| tree | 8865b97eee0c27a5bb436243837ec7d13f0892ba /drivers/pci/msi.c | |
| parent | PCI/MSI: Check kmalloc() return value, fix leak of name (diff) | |
| download | linux-13f81c099bee8141f764fd41a1f4b68b93be3296.tar.xz linux-13f81c099bee8141f764fd41a1f4b68b93be3296.zip | |
PCI/MSI: Fix leak of msi_attrs
Coverity reported that I forgot to clean up some allocated memory on the
error path in populate_msi_sysfs(), so this patch fixes that.
Thanks to Dave Jones for pointing out where the error was, I obviously
can't read code this morning...
Found by Coverity (CID 1163317).
Fixes: 1c51b50c2995 ("PCI/MSI: Export MSI mode using attributes, not kobjects")
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Dave Jones <davej@redhat.com>
Diffstat (limited to '')
| -rw-r--r-- | drivers/pci/msi.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c index 39dff3fe57af..6f0474ebe420 100644 --- a/drivers/pci/msi.c +++ b/drivers/pci/msi.c @@ -595,6 +595,7 @@ error_attrs: ++count; msi_attr = msi_attrs[count]; } + kfree(msi_attrs); return ret; } |