summaryrefslogtreecommitdiffstats
path: root/drivers/pci/msi.c
diff options
context:
space:
mode:
authorBrian Norris <briannorris@chromium.org>2017-04-20 22:36:25 +0200
committerBjorn Helgaas <bhelgaas@google.com>2017-04-28 17:38:00 +0200
commita5f40e8098fe6d983fdb3beb7b50a8067c136141 (patch)
treea98617d22761b5b620ac2af829e15f9afe6d00ea /drivers/pci/msi.c
parentMerge branch 'pci/virtualization' into next (diff)
downloadlinux-a5f40e8098fe6d983fdb3beb7b50a8067c136141.tar.xz
linux-a5f40e8098fe6d983fdb3beb7b50a8067c136141.zip
PCI: Don't allow unbinding host controllers that aren't prepared
Many PCI host controller drivers aren't prepared to have their devices unbound from them forcefully (e.g., through /sys/.../<driver>/unbind), as they don't provide any driver .remove callback, where they'd detach the root bus, release resources, etc. Keeping the driver built in (i.e., not a loadable module) is not enough; and providing no .remove callback just means we don't do any teardown. To rule out the possibility of unbinding a device via sysfs, we need to set the ".suppress_bind_attrs" field. I found the suspect drivers via the following search: git grep -l platform_driver $(git grep -L -e '\.remove' -e suppress_bind_attrs drivers/pci/) Then I inspected them to ensure that (a) they set up a PCI bus in their probe() and (b) they don't have a remove() callback for undoing the setup Suggested-by: Bjorn Helgaas <helgaas@kernel.org> Signed-off-by: Brian Norris <briannorris@chromium.org> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Diffstat (limited to 'drivers/pci/msi.c')
0 files changed, 0 insertions, 0 deletions