summaryrefslogtreecommitdiffstats
path: root/drivers/pci/p2pdma.c
diff options
context:
space:
mode:
authorWen Yang <wen.yang99@zte.com.cn>2019-02-27 05:40:37 +0100
committerLorenzo Pieralisi <lorenzo.pieralisi@arm.com>2019-03-29 17:57:50 +0100
commite12bfa013c0972dd94c2f849e05c87f5e1913e96 (patch)
tree80586d2e5e4ee40f967a0bc87b6d6efb98f751c0 /drivers/pci/p2pdma.c
parentPCI: dwc: pci-dra7xx: Fix a leaked reference by adding missing of_node_put() (diff)
downloadlinux-e12bfa013c0972dd94c2f849e05c87f5e1913e96.tar.xz
linux-e12bfa013c0972dd94c2f849e05c87f5e1913e96.zip
PCI: uniphier: Fix a leaked reference by adding missing of_node_put()
The call to of_get_child_by_name() returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. irq_domain_add_linear() also calls of_node_get() to increase refcount, so irq_domain will not be affected when it is released. Detected by coccinelle with the following warnings: ./drivers/pci/controller/dwc/pcie-uniphier.c:283:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 274, but without a corresponding object release within this function. ./drivers/pci/controller/dwc/pcie-uniphier.c:290:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 274, but without a corresponding object release within this function. ./drivers/pci/controller/dwc/pcie-uniphier.c:296:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 274, but without a corresponding object release within this function. Signed-off-by: Wen Yang <wen.yang99@zte.com.cn> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: Bjorn Helgaas <bhelgaas@google.com> Cc: Masahiro Yamada <yamada.masahiro@socionext.com> Cc: linux-pci@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org
Diffstat (limited to 'drivers/pci/p2pdma.c')
0 files changed, 0 insertions, 0 deletions