summaryrefslogtreecommitdiffstats
path: root/drivers/pci/pcie
diff options
context:
space:
mode:
authorSven Van Asbroeck <thesven73@gmail.com>2019-03-01 17:54:19 +0100
committerBjorn Helgaas <bhelgaas@google.com>2019-03-02 00:45:27 +0100
commit7cf58b79b3072029af127ae865ffc6f00f34b1f8 (patch)
tree632a551a2996a914cb43e1daf38c06fa881bf90d /drivers/pci/pcie
parentPCI/PME: Fix hotplug/sysfs remove deadlock in pcie_pme_remove() (diff)
downloadlinux-7cf58b79b3072029af127ae865ffc6f00f34b1f8.tar.xz
linux-7cf58b79b3072029af127ae865ffc6f00f34b1f8.zip
PCI/PME: Fix possible use-after-free on remove
In remove(), ensure that the PME work cannot run after kfree() is called. Otherwise, this could result in a use-after-free. This issue was detected with the help of Coccinelle. Signed-off-by: Sven Van Asbroeck <TheSven73@gmail.com> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Cc: Sinan Kaya <okaya@kernel.org> Cc: Frederick Lawler <fred@fredlawl.com> Cc: Mika Westerberg <mika.westerberg@linux.intel.com> Cc: Keith Busch <keith.busch@intel.com> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers/pci/pcie')
-rw-r--r--drivers/pci/pcie/pme.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/pci/pcie/pme.c b/drivers/pci/pcie/pme.c
index efa5b552914b..54d593d10396 100644
--- a/drivers/pci/pcie/pme.c
+++ b/drivers/pci/pcie/pme.c
@@ -437,6 +437,7 @@ static void pcie_pme_remove(struct pcie_device *srv)
pcie_pme_disable_interrupt(srv->port, data);
free_irq(srv->irq, srv);
+ cancel_work_sync(&data->work);
kfree(data);
}