diff options
| author | Joerg Roedel <jroedel@suse.de> | 2020-05-25 15:01:22 +0200 |
|---|---|---|
| committer | Joerg Roedel <jroedel@suse.de> | 2020-05-25 15:33:38 +0200 |
| commit | 79659190ee972c05498c338e48d80cb45490c533 (patch) | |
| tree | 906a605f777a78b031fc7d12e3e77c3b3432ebf3 /drivers/pci | |
| parent | iommu: Don't call .probe_finalize() under group->mutex (diff) | |
| download | linux-79659190ee972c05498c338e48d80cb45490c533.tar.xz linux-79659190ee972c05498c338e48d80cb45490c533.zip | |
iommu: Don't take group reference in iommu_alloc_default_domain()
The iommu_alloc_default_domain() function takes a reference to an IOMMU
group without releasing it. This causes the group to never be released,
with undefined side effects.
The function has only one call-site, which takes a group reference on
its own, so to fix this leak, do not take another reference in
iommu_alloc_default_domain() and pass the group as a function parameter
instead.
Fixes: 6e1aa2049154 ("iommu: Move default domain allocation to iommu_probe_device()")
Reported-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Tested-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
Cc: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
Link: https://lore.kernel.org/r/20200525130122.380-1-joro@8bytes.org
Reference: https://lore.kernel.org/lkml/20200522130145.30067-1-saiprakash.ranjan@codeaurora.org/
Diffstat (limited to 'drivers/pci')
0 files changed, 0 insertions, 0 deletions