diff options
| author | Tim Harvey <tharvey@gateworks.com> | 2013-10-18 02:27:22 +0200 |
|---|---|---|
| committer | Bjorn Helgaas <bhelgaas@google.com> | 2013-10-29 20:37:56 +0100 |
| commit | 4ec3ed7f5e91e9325c810dcb995ef5a55e4a79a6 (patch) | |
| tree | 60370d82adb8dcf83ec6b07fab3ea491354b9fd6 /drivers/pci | |
| parent | PCI: imx6: Remove redundant dev_err() in imx6_pcie_probe() (diff) | |
| download | linux-4ec3ed7f5e91e9325c810dcb995ef5a55e4a79a6.tar.xz linux-4ec3ed7f5e91e9325c810dcb995ef5a55e4a79a6.zip | |
PCI: imx6: Fix imprecise abort handler
An imprecise abort is triggered when a port behind a switch is accessed
and no device is present. At enumeration, imprecise aborts are not enabled
thus this ends up getting deferred until the kernel has completed init. At
that point we must not adjust PC - the handler must do nothing, but a
handler must exist.
This fixes random crashes that occur right after freeing init.
Tested-by: Marek Vasut <marex@denx.de>
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
Acked-by: Marek Vasut <marex@denx.de>
Diffstat (limited to 'drivers/pci')
| -rw-r--r-- | drivers/pci/host/pci-imx6.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/drivers/pci/host/pci-imx6.c b/drivers/pci/host/pci-imx6.c index 51338ac5775d..7426ad961b81 100644 --- a/drivers/pci/host/pci-imx6.c +++ b/drivers/pci/host/pci-imx6.c @@ -200,12 +200,6 @@ static int pcie_phy_write(void __iomem *dbi_base, int addr, int data) static int imx6q_pcie_abort_handler(unsigned long addr, unsigned int fsr, struct pt_regs *regs) { - /* - * If it was an imprecise abort, then we need to correct the - * return address to be _after_ the instruction. - */ - if (fsr & (1 << 10)) - regs->ARM_pc += 4; return 0; } |