diff options
| author | Bjorn Helgaas <bhelgaas@google.com> | 2013-08-22 05:24:46 +0200 |
|---|---|---|
| committer | Bjorn Helgaas <bhelgaas@google.com> | 2013-08-22 18:47:04 +0200 |
| commit | c2996948ac36a9082f27b9ad94dac4c821a9c33d (patch) | |
| tree | da7eacb8af784ca903787e01dd2ed4700c70654c /drivers/pci | |
| parent | PCI: Remove unnecessary check for pcie_get_mps() failure (diff) | |
| download | linux-c2996948ac36a9082f27b9ad94dac4c821a9c33d.tar.xz linux-c2996948ac36a9082f27b9ad94dac4c821a9c33d.zip | |
PCI: Simplify MPS test for Downstream Port
PCIe hotplug bridges are always either Root Ports or Downstream Ports. No
other device type can have a PCIe link leading downstream to a slot.
Root Ports don't have an upstream bridge, so "dev->is_hotplug_bridge &&
dev->bus->self" is true if and only if "dev" is a Downstream Port. That
means we can simplify this by looking at the type of "dev" itself, without
looking upstream at all.
No functional change.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Diffstat (limited to 'drivers/pci')
| -rw-r--r-- | drivers/pci/probe.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index ecae7f290647..0591b087a6c3 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -1507,8 +1507,7 @@ static int pcie_find_smpss(struct pci_dev *dev, void *data) * will occur as normal. */ if (dev->is_hotplug_bridge && (!list_is_singular(&dev->bus->devices) || - (dev->bus->self && - pci_pcie_type(dev->bus->self) != PCI_EXP_TYPE_ROOT_PORT))) + pci_pcie_type(dev) != PCI_EXP_TYPE_ROOT_PORT)) *smpss = 0; if (*smpss > dev->pcie_mpss) |