diff options
author | Dan Carpenter <dan.carpenter@oracle.com> | 2013-12-06 13:21:19 +0100 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-12-10 21:53:30 +0100 |
commit | 52797d293287f5a98bd686616527b102b077ac39 (patch) | |
tree | d528d9a75c32613040d691964556d283e38d9a11 /drivers/phy/Kconfig | |
parent | drivers: phy: Fix memory leak (diff) | |
download | linux-52797d293287f5a98bd686616527b102b077ac39.tar.xz linux-52797d293287f5a98bd686616527b102b077ac39.zip |
drivers: phy: tweaks to phy_create()
If this was called with a NULL "dev" then it lead to a NULL dereference
when we called dev_WARN(). I have changed it to WARN_ON() so that we
get a stack dump and can fix the caller.
The rest of this patch is just cleanup like returning directly instead
of having do-nothing gotos. Using descriptive labels instead of
GW-BASIC style "err0" and "err1". I also flipped the order of
put_device() and ida_remove() so they are a mirror reflection of the
order they were allocated.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/phy/Kconfig')
0 files changed, 0 insertions, 0 deletions