diff options
| author | Johannes Thumshirn <jthumshirn@suse.de> | 2017-05-23 16:50:47 +0200 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2017-05-24 21:09:54 +0200 |
| commit | ddff7ed45edce4a4c92949d3c61cd25d229c4a14 (patch) | |
| tree | a2722ad2397a9904f921347e3fe7301a95c7e12e /drivers/phy/phy-bcm-ns-usb3.c | |
| parent | scsi: libcxgbi: fix skb use after free (diff) | |
| download | linux-ddff7ed45edce4a4c92949d3c61cd25d229c4a14.tar.xz linux-ddff7ed45edce4a4c92949d3c61cd25d229c4a14.zip | |
scsi: qla2xxx: don't disable a not previously enabled PCI device
When pci_enable_device() or pci_enable_device_mem() fail in
qla2x00_probe_one() we bail out but do a call to
pci_disable_device(). This causes the dev_WARN_ON() in
pci_disable_device() to trigger, as the device wasn't enabled
previously.
So instead of taking the 'probe_out' error path we can directly return
*iff* one of the pci_enable_device() calls fails.
Additionally rename the 'probe_out' goto label's name to the more
descriptive 'disable_device'.
Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
Fixes: e315cd28b9ef ("[SCSI] qla2xxx: Code changes for qla data structure refactoring")
Cc: <stable@vger.kernel.org>
Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
Reviewed-by: Giridhar Malavali <giridhar.malavali@cavium.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/phy/phy-bcm-ns-usb3.c')
0 files changed, 0 insertions, 0 deletions