diff options
| author | Axel Lin <axel.lin@ingics.com> | 2015-02-27 16:44:24 +0100 |
|---|---|---|
| committer | Kishon Vijay Abraham I <kishon@ti.com> | 2015-03-13 12:44:36 +0100 |
| commit | ecd5fb026d460bf8fb883254fb9bd01a1085c185 (patch) | |
| tree | 623239b4edc7125e3b903d18bdd2a807ba93d0f6 /drivers/phy/phy-exynos5-usbdrd.c | |
| parent | phy: Find the right match in devm_phy_destroy() (diff) | |
| download | linux-ecd5fb026d460bf8fb883254fb9bd01a1085c185.tar.xz linux-ecd5fb026d460bf8fb883254fb9bd01a1085c185.zip | |
phy: exynos5-usbdrd: Fix off-by-one valid value checking for args->args[0]
Current code uses args->args[0] as array subscript of phy_drd->phys[].
So the valid value range for args->args[0] is 0 ... EXYNOS5_DRDPHYS_NUM - 1.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Reviewed by: Vivek Gautam <gautam.vivek@samsung.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Diffstat (limited to 'drivers/phy/phy-exynos5-usbdrd.c')
| -rw-r--r-- | drivers/phy/phy-exynos5-usbdrd.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/phy/phy-exynos5-usbdrd.c b/drivers/phy/phy-exynos5-usbdrd.c index 04374018425f..e2a0be750ad9 100644 --- a/drivers/phy/phy-exynos5-usbdrd.c +++ b/drivers/phy/phy-exynos5-usbdrd.c @@ -531,7 +531,7 @@ static struct phy *exynos5_usbdrd_phy_xlate(struct device *dev, { struct exynos5_usbdrd_phy *phy_drd = dev_get_drvdata(dev); - if (WARN_ON(args->args[0] > EXYNOS5_DRDPHYS_NUM)) + if (WARN_ON(args->args[0] >= EXYNOS5_DRDPHYS_NUM)) return ERR_PTR(-ENODEV); return phy_drd->phys[args->args[0]].phy; |