diff options
| author | Samuel Holland <samuel@sholland.org> | 2022-04-14 05:22:54 +0200 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2022-04-20 11:14:03 +0200 |
| commit | 5a709a46e4270a6130877c052260d9a6d14ac685 (patch) | |
| tree | ecabeaaa4924d914c5f7019a8e01db6d463f6377 /drivers/phy | |
| parent | phy: rockchip-inno-usb2: Do not check bvalid twice (diff) | |
| download | linux-5a709a46e4270a6130877c052260d9a6d14ac685.tar.xz linux-5a709a46e4270a6130877c052260d9a6d14ac685.zip | |
phy: rockchip-inno-usb2: Do not lock in bvalid IRQ handler
Clearing the IRQ is atomic, so there is no need to hold the mutex.
Signed-off-by: Samuel Holland <samuel@sholland.org>
Tested-by: Michael Riesch <michael.riesch@wolfvision.net>
Link: https://lore.kernel.org/r/20220414032258.40984-4-samuel@sholland.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/phy')
| -rw-r--r-- | drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c index 29407b36f5fa..3422db56be76 100644 --- a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c +++ b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c @@ -905,13 +905,9 @@ static irqreturn_t rockchip_usb2phy_bvalid_irq(int irq, void *data) if (!property_enabled(rphy->grf, &rport->port_cfg->bvalid_det_st)) return IRQ_NONE; - mutex_lock(&rport->mutex); - /* clear bvalid detect irq pending status */ property_enable(rphy->grf, &rport->port_cfg->bvalid_det_clr, true); - mutex_unlock(&rport->mutex); - rockchip_usb2phy_otg_sm_work(&rport->otg_sm_work.work); return IRQ_HANDLED; |