diff options
author | Nikita Yushchenko <nikita.yoush@cogentembedded.com> | 2016-12-04 16:49:28 +0100 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-01-12 11:51:24 +0100 |
commit | 54a44d54be3a7394ebea42bbffd67819e0f3f89a (patch) | |
tree | c0ea4f537ae797ba0354d0b7eefa5662c8d81591 /drivers/pinctrl/pinctrl-falcon.c | |
parent | tty: serial: sh-sci: set error code when kasprintf fails (diff) | |
download | linux-54a44d54be3a7394ebea42bbffd67819e0f3f89a.tar.xz linux-54a44d54be3a7394ebea42bbffd67819e0f3f89a.zip |
tty: serial: fsl_lpuart: fix del_timer_sync() vs timer routine deadlock
Problem found via lockdep:
- lpuart_set_termios() calls del_timer_sync(&sport->lpuart_timer) while
holding sport->port.lock
- sport->lpuart_timer routine is lpuart_timer_func() that calls
lpuart_copy_rx_to_tty() that acquires same lock.
To fix, move Rx DMA stopping out of lock, as it already is in other places
in the same file.
While at it, also make Rx DMA start/stop code to look the same is in
other places in the same file.
Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Tested-by: Stefan Agner <stefan@agner.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/pinctrl/pinctrl-falcon.c')
0 files changed, 0 insertions, 0 deletions