diff options
| author | Sascha Hauer <s.hauer@pengutronix.de> | 2013-08-09 14:20:51 +0200 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2013-08-15 22:13:11 +0200 |
| commit | 1bf1fea95ff9161fafccbcac76b37bbadc924bd0 (patch) | |
| tree | 91c9abed69eb312d98495a8cc121249e80007d35 /drivers/pinctrl/pinctrl-imx.c | |
| parent | pinctrl: imx: make error messages more informative (diff) | |
| download | linux-1bf1fea95ff9161fafccbcac76b37bbadc924bd0.tar.xz linux-1bf1fea95ff9161fafccbcac76b37bbadc924bd0.zip | |
pinctrl: imx: Catch no fsl,pins property
Instead of crashing the kernel print an error message when
the fsl,pins property is missing.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to '')
| -rw-r--r-- | drivers/pinctrl/pinctrl-imx.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/pinctrl/pinctrl-imx.c b/drivers/pinctrl/pinctrl-imx.c index f1be17f6fcf1..deeb740fa94e 100644 --- a/drivers/pinctrl/pinctrl-imx.c +++ b/drivers/pinctrl/pinctrl-imx.c @@ -456,6 +456,11 @@ static int imx_pinctrl_parse_groups(struct device_node *np, * do sanity check and calculate pins number */ list = of_get_property(np, "fsl,pins", &size); + if (!list) { + dev_err(info->dev, "no fsl,pins property in node %s\n", np->full_name); + return -EINVAL; + } + /* we do not check return since it's safe node passed down */ if (!size || size % pin_size) { dev_err(info->dev, "Invalid fsl,pins property in node %s\n", np->full_name); |