summaryrefslogtreecommitdiffstats
path: root/drivers/pinctrl/pinctrl-st.c
diff options
context:
space:
mode:
authorDoug Anderson <dianders@chromium.org>2014-11-19 23:51:33 +0100
committerLinus Walleij <linus.walleij@linaro.org>2014-12-30 13:17:27 +0100
commitf2dd028c2632d107c26b1daed543d9efd4f0decd (patch)
treebcdd09a8392ca258ef81eac43c1a486f65e79272 /drivers/pinctrl/pinctrl-st.c
parentpinctrl: rockchip: Handle wakeup pins (diff)
downloadlinux-f2dd028c2632d107c26b1daed543d9efd4f0decd.tar.xz
linux-f2dd028c2632d107c26b1daed543d9efd4f0decd.zip
pinctrl: rockchip: Fix enable/disable/mask/unmask
The Rockchip pinctrl driver was only implementing the "mask" and "unmask" operations though the hardware actually has two distinct things: enable/disable and mask/unmask. It was implementing the "mask" operations as a hardware enable/disable and always leaving all interrupts unmasked. I believe that the old system had some downsides, specifically: - (Untested) if an interrupt went off while interrupts were "masked" it would be lost. Now it will be kept track of. - If someone wanted to change an interrupt back into a GPIO (is such a thing sensible?) by calling irq_disable() it wouldn't actually take effect. That's because Linux does some extra optimizations when there's no true "disable" function: it does a lazy mask. Let's actually implement enable/disable/mask/unmask properly. Signed-off-by: Doug Anderson <dianders@chromium.org> Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Reviewed-by: Heiko Stuebner <heiko@sntech.de> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl/pinctrl-st.c')
0 files changed, 0 insertions, 0 deletions