summaryrefslogtreecommitdiffstats
path: root/drivers/pinctrl/tegra
diff options
context:
space:
mode:
authorThierry Reding <thierry.reding@gmail.com>2019-09-23 11:54:00 +0200
committerLinus Walleij <linus.walleij@linaro.org>2019-10-04 23:20:04 +0200
commit9978339ae4e08fd6b7c8200db0fff9dbe6e034d2 (patch)
tree524209ae3a93085c02399a6ddd603020d1781fb2 /drivers/pinctrl/tegra
parentpinctl: ti: iodelay: fix error checking on pinctrl_count_index_with_args call (diff)
downloadlinux-9978339ae4e08fd6b7c8200db0fff9dbe6e034d2.tar.xz
linux-9978339ae4e08fd6b7c8200db0fff9dbe6e034d2.zip
pinctrl: tegra: xusb: Add note about legacy status
Add a comment about why the call to of_match_node() cannot be replaced by of_device_get_match_data(). This will hopefully prevent people from attempting to clean this up in the future. Signed-off-by: Thierry Reding <treding@nvidia.com> Link: https://lore.kernel.org/r/20190923095400.GA11084@ulmo Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl/tegra')
-rw-r--r--drivers/pinctrl/tegra/pinctrl-tegra-xusb.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/pinctrl/tegra/pinctrl-tegra-xusb.c b/drivers/pinctrl/tegra/pinctrl-tegra-xusb.c
index 95002e3ecaff..f2fa1f76ebb7 100644
--- a/drivers/pinctrl/tegra/pinctrl-tegra-xusb.c
+++ b/drivers/pinctrl/tegra/pinctrl-tegra-xusb.c
@@ -885,6 +885,12 @@ int tegra_xusb_padctl_legacy_probe(struct platform_device *pdev)
mutex_init(&padctl->lock);
padctl->dev = &pdev->dev;
+ /*
+ * Note that we can't replace this by of_device_get_match_data()
+ * because we need the separate matching table for this legacy code on
+ * Tegra124. of_device_get_match_data() would attempt to use the table
+ * from the updated driver and fail.
+ */
match = of_match_node(tegra_xusb_padctl_of_match, pdev->dev.of_node);
padctl->soc = match->data;