diff options
author | Binbin Wu <binbin.wu@intel.com> | 2019-04-08 12:49:26 +0200 |
---|---|---|
committer | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2019-04-09 17:26:44 +0200 |
commit | 2fef32766861c6e171f436ab99c89198cf0ca6e1 (patch) | |
tree | 969fb46178241a96e59625f5fce31b9e07de86f3 /drivers/pinctrl/vt8500 | |
parent | pinctrl: cedarfork: Update pin names according to v1.13c (diff) | |
download | linux-2fef32766861c6e171f436ab99c89198cf0ca6e1.tar.xz linux-2fef32766861c6e171f436ab99c89198cf0ca6e1.zip |
pinctrl: pinctrl-intel: move gpio suspend/resume to noirq phase
In current driver, SET_LATE_SYSTEM_SLEEP_PM_OPS is used to install the
callbacks for suspend/resume.
GPIO pin may be used as the interrupt pin by some device. However, using
SET_LATE_SYSTEM_SLEEP_PM_OPS() to install the callbacks, the resume
callback is called after resume_device_irqs(). Unintended interrupts may
arrive due to resuming device irqs first, but the GPIO controller is not
properly restored.
Normally, for a SMP system, there are multiple cores, so even when there are
unintended interrupts, BSP gets the chance to initialize the GPIO chip soon.
But when there is only 1 core is active (other cores are offlined or
single core) during resume, it is more easily to observe the unintended
interrupts.
This patch renames the suspend/resume function by adding suffix "_noirq",
and installs the callbacks using SET_NOIRQ_SYSTEM_SLEEP_PM_OPS().
Signed-off-by: Binbin Wu <binbin.wu@intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Diffstat (limited to 'drivers/pinctrl/vt8500')
0 files changed, 0 insertions, 0 deletions