diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2013-11-14 09:22:54 +0100 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2013-11-25 09:08:18 +0100 |
| commit | d32c3e260f95f5d8ed42c64dc2d9ec79cc36da1e (patch) | |
| tree | 97651583914bd813b25b8ef3726cd6e48a0b748a /drivers/pinctrl | |
| parent | pinctrl: abx500: fix some more bitwise AND tests (diff) | |
| download | linux-d32c3e260f95f5d8ed42c64dc2d9ec79cc36da1e.tar.xz linux-d32c3e260f95f5d8ed42c64dc2d9ec79cc36da1e.zip | |
pinctrl: rockchip: missing unlock on error in rockchip_set_pull()
We need to unlock here before returning -EINVAL.
Fixes: 6ca5274d1d12 ('pinctrl: rockchip: add rk3188 specifics')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl')
| -rw-r--r-- | drivers/pinctrl/pinctrl-rockchip.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c index fe2ec1bdf56e..46dddc159286 100644 --- a/drivers/pinctrl/pinctrl-rockchip.c +++ b/drivers/pinctrl/pinctrl-rockchip.c @@ -504,6 +504,7 @@ static int rockchip_set_pull(struct rockchip_pin_bank *bank, data |= (3 << bit); break; default: + spin_unlock_irqrestore(&bank->slock, flags); dev_err(info->dev, "unsupported pull setting %d\n", pull); return -EINVAL; |