diff options
| author | Colin Ian King <colin.king@canonical.com> | 2017-01-13 14:20:39 +0100 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2017-01-18 10:23:37 +0100 |
| commit | 731d43cd6bacd39c39b5c957fa2bb0031bda0dce (patch) | |
| tree | 168e2b85062ec22ceb4f4638c70a58d51b6b9cc4 /drivers/pinctrl | |
| parent | pinctrl: mvebu: add simple regmap based pinctrl implementation (diff) | |
| download | linux-731d43cd6bacd39c39b5c957fa2bb0031bda0dce.tar.xz linux-731d43cd6bacd39c39b5c957fa2bb0031bda0dce.zip | |
pinctrl: ti-iodelay: remove redundant pin < 0 check on unsigned int
pin is an unsigned int and therefore can never be < 0 so
this check is redundant. Remove the check and the associated
dev_err error message.
Fixes CoverityScan CID#1396438 ("Unsigned compared against 0")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl')
| -rw-r--r-- | drivers/pinctrl/ti/pinctrl-ti-iodelay.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/drivers/pinctrl/ti/pinctrl-ti-iodelay.c b/drivers/pinctrl/ti/pinctrl-ti-iodelay.c index 7f472f123515..717e3404900c 100644 --- a/drivers/pinctrl/ti/pinctrl-ti-iodelay.c +++ b/drivers/pinctrl/ti/pinctrl-ti-iodelay.c @@ -665,12 +665,6 @@ static void ti_iodelay_pin_dbg_show(struct pinctrl_dev *pctldev, r = iod->reg_data; offset = ti_iodelay_pin_to_offset(iod, pin); - if (pin < 0) { - dev_err(iod->dev, "invalid pin offset for pin%i\n", pin); - - return; - } - pd = &iod->pa[pin]; cfg = pd->drv_data; |