diff options
| author | Hans de Goede <hdegoede@redhat.com> | 2022-06-18 17:15:24 +0200 |
|---|---|---|
| committer | Hans de Goede <hdegoede@redhat.com> | 2022-09-03 12:17:27 +0200 |
| commit | 52796b304a517b002300bbb67074b38a6003fd7a (patch) | |
| tree | 0bdc6b47a5e2e1cbd5cc83d321335e519254ec1f /drivers/platform/x86/asus-wmi.h | |
| parent | platform/x86: asus-wmi: Drop DMI chassis-type check from backlight handling (diff) | |
| download | linux-52796b304a517b002300bbb67074b38a6003fd7a.tar.xz linux-52796b304a517b002300bbb67074b38a6003fd7a.zip | |
platform/x86: asus-wmi: Move acpi_backlight=vendor quirks to ACPI video_detect.c
Remove the asus-wmi quirk_entry.wmi_backlight_power quirk-flag, which
called acpi_video_set_dmi_backlight_type(acpi_backlight_vendor) and replace
it with acpi/video_detect.c video_detect_dmi_table[] entries using the
video_detect_force_vendor callback.
acpi_video_set_dmi_backlight_type() is troublesome because it may end up
getting called after other backlight drivers have already called
acpi_video_get_backlight_type() resulting in the other drivers
already being registered even though they should not.
Note no entries are dropped from the dmi_system_id table in asus-nb-wmi.c.
This is because the entries using the removed wmi_backlight_power flag
also use other model specific quirks from the asus-wmi quirk_entry struct.
So the quirk_asus_x55u struct and the entries pointing to it cannot be
dropped.
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Diffstat (limited to 'drivers/platform/x86/asus-wmi.h')
| -rw-r--r-- | drivers/platform/x86/asus-wmi.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/platform/x86/asus-wmi.h b/drivers/platform/x86/asus-wmi.h index b302415bf1d9..30770e411301 100644 --- a/drivers/platform/x86/asus-wmi.h +++ b/drivers/platform/x86/asus-wmi.h @@ -29,7 +29,6 @@ struct quirk_entry { bool hotplug_wireless; bool scalar_panel_brightness; bool store_backlight_power; - bool wmi_backlight_power; bool wmi_backlight_native; bool wmi_backlight_set_devstate; bool wmi_force_als_set; |