diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2023-03-02 15:47:24 +0100 |
|---|---|---|
| committer | Hans de Goede <hdegoede@redhat.com> | 2023-03-07 12:20:33 +0100 |
| commit | 6ee08b4eba3d36d5cc2bf1594040de95ae12ee7d (patch) | |
| tree | 2600375896cb58f7881fbe57840ff6fd12e1c68b /drivers/platform/x86/intel/int3472 | |
| parent | platform/x86: intel: int1092: intel_sar: Convert to platform remove callback ... (diff) | |
| download | linux-6ee08b4eba3d36d5cc2bf1594040de95ae12ee7d.tar.xz linux-6ee08b4eba3d36d5cc2bf1594040de95ae12ee7d.zip | |
platform/x86: intel: int3472: discrete: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230302144732.1903781-22-u.kleine-koenig@pengutronix.de
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Diffstat (limited to 'drivers/platform/x86/intel/int3472')
| -rw-r--r-- | drivers/platform/x86/intel/int3472/discrete.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/platform/x86/intel/int3472/discrete.c b/drivers/platform/x86/intel/int3472/discrete.c index f064da74f50a..ef020e23e596 100644 --- a/drivers/platform/x86/intel/int3472/discrete.c +++ b/drivers/platform/x86/intel/int3472/discrete.c @@ -317,7 +317,7 @@ static int skl_int3472_parse_crs(struct int3472_discrete_device *int3472) return 0; } -static int skl_int3472_discrete_remove(struct platform_device *pdev) +static void skl_int3472_discrete_remove(struct platform_device *pdev) { struct int3472_discrete_device *int3472 = platform_get_drvdata(pdev); @@ -326,8 +326,6 @@ static int skl_int3472_discrete_remove(struct platform_device *pdev) skl_int3472_unregister_clock(int3472); skl_int3472_unregister_pled(int3472); skl_int3472_unregister_regulator(int3472); - - return 0; } static int skl_int3472_discrete_probe(struct platform_device *pdev) @@ -392,7 +390,7 @@ static struct platform_driver int3472_discrete = { .acpi_match_table = int3472_device_id, }, .probe = skl_int3472_discrete_probe, - .remove = skl_int3472_discrete_remove, + .remove_new = skl_int3472_discrete_remove, }; module_platform_driver(int3472_discrete); |