summaryrefslogtreecommitdiffstats
path: root/drivers/platform/x86/wmi.c
diff options
context:
space:
mode:
authorDan Carpenter <error27@gmail.com>2010-12-06 22:44:23 +0100
committerMatthew Garrett <mjg@redhat.com>2011-01-07 23:03:45 +0100
commite1e0dacba5af2b0cd8f9043d0b937296c90bc990 (patch)
tree70a4dea5b47cf51693ea16f3a981e3444273c780 /drivers/platform/x86/wmi.c
parenteeepc-wmi: never load if legacy device is enabled (diff)
downloadlinux-e1e0dacba5af2b0cd8f9043d0b937296c90bc990.tar.xz
linux-e1e0dacba5af2b0cd8f9043d0b937296c90bc990.zip
WMI: return error if wmi_create_device() fails
The break resets the retval to 0 but we want to return an error code. This was introduced in c64eefd48c4 "WMI: embed struct device directly into wmi_block" Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Matthew Garrett <mjg@redhat.com> Acked-by: Dmitry Torokhov <dtor@mail.ru>
Diffstat (limited to 'drivers/platform/x86/wmi.c')
-rw-r--r--drivers/platform/x86/wmi.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c
index b8e5383eab0c..05cc79672a8b 100644
--- a/drivers/platform/x86/wmi.c
+++ b/drivers/platform/x86/wmi.c
@@ -820,7 +820,7 @@ static acpi_status parse_wdg(acpi_handle handle)
retval = wmi_create_device(&gblock[i], wblock, handle);
if (retval) {
wmi_free_devices();
- break;
+ goto out_free_pointer;
}
}