diff options
| author | Hans de Goede <hdegoede@redhat.com> | 2021-01-15 00:27:44 +0100 |
|---|---|---|
| committer | Hans de Goede <hdegoede@redhat.com> | 2021-01-18 21:38:43 +0100 |
| commit | dbd7dd8f8859ac3ab556c76d9b02efb96c26df80 (patch) | |
| tree | d53d281cc4903ee95803ce1256056b18dc495750 /drivers/platform | |
| parent | platform/x86: intel-vbtn: Drop HP Stream x360 Convertible PC 11 from allow-list (diff) | |
| download | linux-dbd7dd8f8859ac3ab556c76d9b02efb96c26df80.tar.xz linux-dbd7dd8f8859ac3ab556c76d9b02efb96c26df80.zip | |
platform/x86: hp-wmi: Don't log a warning on HPWMI_RET_UNKNOWN_COMMAND errors
The recently added thermal policy support makes a
hp_wmi_perform_query(0x4c, ...) call on older devices which do not
support thermal policies this causes the following warning to be
logged (seen on a HP Stream x360 Convertible PC 11):
[ 26.805305] hp_wmi: query 0x4c returned error 0x3
Error 0x3 is HPWMI_RET_UNKNOWN_COMMAND error. This commit silences
the warning for unknown-command errors, silencing the new warning.
Cc: Elia Devito <eliadevito@gmail.com>
Fixes: 81c93798ef3e ("platform/x86: hp-wmi: add support for thermal policy")
Link: https://lore.kernel.org/r/20210114232744.154886-1-hdegoede@redhat.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Diffstat (limited to 'drivers/platform')
| -rw-r--r-- | drivers/platform/x86/hp-wmi.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c index ecd477964d11..18bf8aeb5f87 100644 --- a/drivers/platform/x86/hp-wmi.c +++ b/drivers/platform/x86/hp-wmi.c @@ -247,7 +247,8 @@ static int hp_wmi_perform_query(int query, enum hp_wmi_command command, ret = bios_return->return_code; if (ret) { - if (ret != HPWMI_RET_UNKNOWN_CMDTYPE) + if (ret != HPWMI_RET_UNKNOWN_COMMAND && + ret != HPWMI_RET_UNKNOWN_CMDTYPE) pr_warn("query 0x%x returned error 0x%x\n", query, ret); goto out_free; } |