diff options
| author | Maximilian Luz <luzmaximilian@gmail.com> | 2021-06-04 15:25:40 +0200 |
|---|---|---|
| committer | Hans de Goede <hdegoede@redhat.com> | 2021-06-16 17:47:52 +0200 |
| commit | a32348b743eec51ac01334735a0b6c979157b132 (patch) | |
| tree | 979bbeafde015277f6093a34bb5482b9e85dbc0a /drivers/platform | |
| parent | platform/x86: dell-wmi-sysman: fw_attr_inuse can be static (diff) | |
| download | linux-a32348b743eec51ac01334735a0b6c979157b132.tar.xz linux-a32348b743eec51ac01334735a0b6c979157b132.zip | |
platform/surface: dtx: Add missing mutex_destroy() call in failure path
When we fail to open the device file due to DTX being shut down, the
mutex is initialized but never destroyed. We are destroying it when
releasing the file, so add the missing call in the failure path as well.
Fixes: 1d609992832e ("platform/surface: Add DTX driver")
Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>
Link: https://lore.kernel.org/r/20210604132540.533036-1-luzmaximilian@gmail.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Diffstat (limited to 'drivers/platform')
| -rw-r--r-- | drivers/platform/surface/surface_dtx.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/platform/surface/surface_dtx.c b/drivers/platform/surface/surface_dtx.c index 5d9b758a99bb..1203b9a82993 100644 --- a/drivers/platform/surface/surface_dtx.c +++ b/drivers/platform/surface/surface_dtx.c @@ -427,6 +427,7 @@ static int surface_dtx_open(struct inode *inode, struct file *file) */ if (test_bit(SDTX_DEVICE_SHUTDOWN_BIT, &ddev->flags)) { up_write(&ddev->client_lock); + mutex_destroy(&client->read_lock); sdtx_device_put(client->ddev); kfree(client); return -ENODEV; |