diff options
| author | Anton Vorontsov <anton.vorontsov@linaro.org> | 2012-08-23 04:29:44 +0200 |
|---|---|---|
| committer | Anton Vorontsov <anton.vorontsov@linaro.org> | 2012-08-23 04:31:42 +0200 |
| commit | bc909f27f55ceb8f950ced5cf3a26d6b26e86ca6 (patch) | |
| tree | 6f605a41e4113855f13b907417895ec7aaef2323 /drivers/power/da9052-battery.c | |
| parent | lp8727_charger: Unregister power supply at error path of lp8727_register_psy (diff) | |
| download | linux-bc909f27f55ceb8f950ced5cf3a26d6b26e86ca6.tar.xz linux-bc909f27f55ceb8f950ced5cf3a26d6b26e86ca6.zip | |
da9052-battery: Fix da9052_determine_vc_tbl_index's return value
The patch fixes the following warnings:
CHECK drivers/power/da9052-battery.c
drivers/power/da9052-battery.c:330:15: warning: symbol 'da9052_determine_vc_tbl_index' was not declared. Should it be static?
CC drivers/power/da9052-battery.o
drivers/power/da9052-battery.c: In function 'da9052_determine_vc_tbl_index':
drivers/power/da9052-battery.c:348:1: warning: control reaches end of non-void function [-Wreturn-type]
Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
Diffstat (limited to 'drivers/power/da9052-battery.c')
| -rw-r--r-- | drivers/power/da9052-battery.c | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/drivers/power/da9052-battery.c b/drivers/power/da9052-battery.c index a5f6a0ec1572..20b86ed946e3 100644 --- a/drivers/power/da9052-battery.c +++ b/drivers/power/da9052-battery.c @@ -327,7 +327,7 @@ static int da9052_bat_interpolate(int vbat_lower, int vbat_upper, return tmp; } -unsigned char da9052_determine_vc_tbl_index(unsigned char adc_temp) +static unsigned char da9052_determine_vc_tbl_index(unsigned char adc_temp) { int i; @@ -345,6 +345,13 @@ unsigned char da9052_determine_vc_tbl_index(unsigned char adc_temp) && (adc_temp <= vc_tbl_ref[i])) return i + 1; } + /* + * For some reason authors of the driver didn't presume that we can + * end up here. It might be OK, but might be not, no one knows for + * sure. Go check your battery, is it on fire? + */ + WARN_ON(1); + return 0; } static int da9052_bat_read_capacity(struct da9052_battery *bat, int *capacity) |