diff options
| author | Ondrej Jirman <megi@xff.cz> | 2022-10-29 00:40:52 +0200 |
|---|---|---|
| committer | Sebastian Reichel <sre@kernel.org> | 2022-11-01 00:02:36 +0100 |
| commit | f9be5cb6c1f0191f8bcf4413b7e17e58e8dfaaa1 (patch) | |
| tree | 29deaa1db07ea6a611273463b9040f979b5da204 /drivers/power/supply/ip5xxx_power.c | |
| parent | power: supply: rk817: Change rk817_chg_cur_to_reg to int (diff) | |
| download | linux-f9be5cb6c1f0191f8bcf4413b7e17e58e8dfaaa1.tar.xz linux-f9be5cb6c1f0191f8bcf4413b7e17e58e8dfaaa1.zip | |
power: supply: ip5xxx: Fix integer overflow in current_now calculation
When current is larger than ~2A, the multiplication in current_now
property overflows and the kernel reports invalid negative current
value. Change the numerator and denominator while preserving their
ratio to allow up to +-6A before the overflow.
Fixes: 75853406fa27 ("power: supply: Add a driver for Injoinic power bank ICs")
Signed-off-by: Ondrej Jirman <megi@xff.cz>
Reviewed-by: Samuel Holland <samuel@sholland.org>
[use 149197/200 instead of 261095/350 as suggested by Samuel]
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Diffstat (limited to 'drivers/power/supply/ip5xxx_power.c')
| -rw-r--r-- | drivers/power/supply/ip5xxx_power.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/power/supply/ip5xxx_power.c b/drivers/power/supply/ip5xxx_power.c index 218e8e689a3f..00221e9c0bfc 100644 --- a/drivers/power/supply/ip5xxx_power.c +++ b/drivers/power/supply/ip5xxx_power.c @@ -352,7 +352,7 @@ static int ip5xxx_battery_get_property(struct power_supply *psy, ret = ip5xxx_battery_read_adc(ip5xxx, IP5XXX_BATIADC_DAT0, IP5XXX_BATIADC_DAT1, &raw); - val->intval = DIV_ROUND_CLOSEST(raw * 745985, 1000); + val->intval = DIV_ROUND_CLOSEST(raw * 149197, 200); return 0; case POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT: |