diff options
| author | Pan Bian <bianpan2016@163.com> | 2017-04-24 10:22:08 +0200 |
|---|---|---|
| committer | Sebastian Reichel <sre@kernel.org> | 2017-05-01 11:52:25 +0200 |
| commit | 8b20839988f1ed5e534b270f3776709b640dc7e0 (patch) | |
| tree | d1963cd2437b0e124c8bf926bf5a941b8abd0ce1 /drivers/power/supply/isp1704_charger.c | |
| parent | power: supply: generic-adc-battery: use SIMPLE_DEV_PM_OPS helper macro (diff) | |
| download | linux-8b20839988f1ed5e534b270f3776709b640dc7e0.tar.xz linux-8b20839988f1ed5e534b270f3776709b640dc7e0.zip | |
power: supply: isp1704: Fix unchecked return value of devm_kzalloc
Function devm_kzalloc() will return a NULL pointer. However, in function
isp1704_charger_probe(), the return value of devm_kzalloc() is directly
used without validation. This may result in a bad memory access bug.
Fixes: 34a109610e2a ("isp1704_charger: Add DT support")
Signed-off-by: Pan Bian <bianpan2016@163.com>
Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Diffstat (limited to 'drivers/power/supply/isp1704_charger.c')
| -rw-r--r-- | drivers/power/supply/isp1704_charger.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/power/supply/isp1704_charger.c b/drivers/power/supply/isp1704_charger.c index 4cd6899b961e..95af5f305838 100644 --- a/drivers/power/supply/isp1704_charger.c +++ b/drivers/power/supply/isp1704_charger.c @@ -418,6 +418,10 @@ static int isp1704_charger_probe(struct platform_device *pdev) pdata = devm_kzalloc(&pdev->dev, sizeof(struct isp1704_charger_data), GFP_KERNEL); + if (!pdata) { + ret = -ENOMEM; + goto fail0; + } pdata->enable_gpio = gpio; dev_info(&pdev->dev, "init gpio %d\n", pdata->enable_gpio); |