diff options
| author | Yang Yingliang <yangyingliang@huawei.com> | 2022-09-21 17:29:15 +0200 |
|---|---|---|
| committer | Sebastian Reichel <sebastian.reichel@collabora.com> | 2022-10-01 22:17:45 +0200 |
| commit | 5738d49fa47e0046050f5e62e4921d667b7ee3c3 (patch) | |
| tree | 9ef810cfe83ce564e401e511d1d827566f8872ab /drivers/power/supply/mt6370-charger.c | |
| parent | power: supply: ab8500: Remove unused struct ab8500_chargalg_sysfs_entry (diff) | |
| download | linux-5738d49fa47e0046050f5e62e4921d667b7ee3c3.tar.xz linux-5738d49fa47e0046050f5e62e4921d667b7ee3c3.zip | |
power: supply: mt6370: Fix return value check in mt6370_chg_probe()
If create_singlethread_workqueue() fails, it returns a null pointer,
replace IS_ERR() check with NULL pointer check.
Fixes: 233cb8a47d65 ("power: supply: mt6370: Add MediaTek MT6370 charger driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: ChiaEn Wu <chiaen_wu@richtek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Diffstat (limited to 'drivers/power/supply/mt6370-charger.c')
| -rw-r--r-- | drivers/power/supply/mt6370-charger.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/power/supply/mt6370-charger.c b/drivers/power/supply/mt6370-charger.c index 716cba259a7a..f27dae5043f5 100644 --- a/drivers/power/supply/mt6370-charger.c +++ b/drivers/power/supply/mt6370-charger.c @@ -911,8 +911,8 @@ static int mt6370_chg_probe(struct platform_device *pdev) priv->attach = MT6370_ATTACH_STAT_DETACH; priv->wq = create_singlethread_workqueue(dev_name(priv->dev)); - if (IS_ERR(priv->wq)) - return dev_err_probe(dev, PTR_ERR(priv->wq), + if (!priv->wq) + return dev_err_probe(dev, -ENOMEM, "Failed to create workqueue\n"); ret = devm_add_action_or_reset(dev, mt6370_chg_destroy_wq, priv->wq); |