diff options
| author | Markus Elfring <elfring@users.sourceforge.net> | 2015-11-06 16:48:46 +0100 |
|---|---|---|
| committer | Sebastian Reichel <sre@kernel.org> | 2015-12-05 02:04:03 +0100 |
| commit | b7e16ec6e3d2ea0b62cf93a0e849db55f403a871 (patch) | |
| tree | f05d08a51e7823607898b35372656d9a48e99653 /drivers/power | |
| parent | Linux 4.4-rc3 (diff) | |
| download | linux-b7e16ec6e3d2ea0b62cf93a0e849db55f403a871.tar.xz linux-b7e16ec6e3d2ea0b62cf93a0e849db55f403a871.zip | |
power: bq2415x_charger: Delete unnecessary checks before the function call "of_node_put"
The of_node_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the calls is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Pali Rohár <pali.rohar@gmail.com>
Signed-off-by: Sebastian Reichel <sre@kernel.org>
Diffstat (limited to 'drivers/power')
| -rw-r--r-- | drivers/power/bq2415x_charger.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/power/bq2415x_charger.c b/drivers/power/bq2415x_charger.c index 4afd76848bce..27e89536689a 100644 --- a/drivers/power/bq2415x_charger.c +++ b/drivers/power/bq2415x_charger.c @@ -1704,7 +1704,7 @@ error_4: error_3: bq2415x_power_supply_exit(bq); error_2: - if (bq && bq->notify_node) + if (bq) of_node_put(bq->notify_node); kfree(name); error_1: @@ -1724,9 +1724,7 @@ static int bq2415x_remove(struct i2c_client *client) if (bq->nb.notifier_call) power_supply_unreg_notifier(&bq->nb); - if (bq->notify_node) - of_node_put(bq->notify_node); - + of_node_put(bq->notify_node); bq2415x_sysfs_exit(bq); bq2415x_power_supply_exit(bq); |