diff options
| author | Dinghao Liu <dinghao.liu@zju.edu.cn> | 2021-03-03 13:12:36 +0100 |
|---|---|---|
| committer | Sebastian Reichel <sebastian.reichel@collabora.com> | 2021-03-15 01:07:54 +0100 |
| commit | 17e499a7d6b52ff3be565a2f6184883dd1fdd9af (patch) | |
| tree | f01aaddee48b25008fdeeb60b22c7a20102e98e2 /drivers/power | |
| parent | power: supply: z2_battery: Drop unused variable (diff) | |
| download | linux-17e499a7d6b52ff3be565a2f6184883dd1fdd9af.tar.xz linux-17e499a7d6b52ff3be565a2f6184883dd1fdd9af.zip | |
power: supply: axp20x_usb_power: Add missing check in axp20x_usb_power_probe
There are two regmap_update_bits() calls but only one of them has
return value check, which is odd. Add a return value check and
terminate the execution flow on failure just like the other call.
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Diffstat (limited to 'drivers/power')
| -rw-r--r-- | drivers/power/supply/axp20x_usb_power.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/power/supply/axp20x_usb_power.c b/drivers/power/supply/axp20x_usb_power.c index 8933ae26c3d6..7ed76eef8417 100644 --- a/drivers/power/supply/axp20x_usb_power.c +++ b/drivers/power/supply/axp20x_usb_power.c @@ -614,8 +614,10 @@ static int axp20x_usb_power_probe(struct platform_device *pdev) if (power->axp20x_id == AXP813_ID) { /* Enable USB Battery Charging specification detection */ - regmap_update_bits(axp20x->regmap, AXP288_BC_GLOBAL, + ret = regmap_update_bits(axp20x->regmap, AXP288_BC_GLOBAL, AXP813_BC_EN, AXP813_BC_EN); + if (ret) + return ret; } psy_cfg.of_node = pdev->dev.of_node; |