diff options
| author | Joonwoo Park <joonwpark81@gmail.com> | 2009-08-26 23:29:18 +0200 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-08-27 05:06:52 +0200 |
| commit | 054b2b13ccba4876a1ce98a7ede7dab7d6893d01 (patch) | |
| tree | 0421da355e30375d251e0fdb570fce2518e7a201 /drivers/pps/pps.c | |
| parent | Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6 (diff) | |
| download | linux-054b2b13ccba4876a1ce98a7ede7dab7d6893d01.tar.xz linux-054b2b13ccba4876a1ce98a7ede7dab7d6893d01.zip | |
pps: fix incorrect verdict check
Fix incorrect verdict check and returns error if device_create failed,
otherwise driver triggers kernel oops.
Signed-off-by: Joonwoo Park<joonwpark81@gmail.com>
Cc: Rodolfo Giometti <giometti@enneenne.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to '')
| -rw-r--r-- | drivers/pps/pps.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/pps/pps.c b/drivers/pps/pps.c index ac8cc8cea1e3..fea17e7805e9 100644 --- a/drivers/pps/pps.c +++ b/drivers/pps/pps.c @@ -244,7 +244,7 @@ int pps_register_cdev(struct pps_device *pps) } pps->dev = device_create(pps_class, pps->info.dev, pps->devno, NULL, "pps%d", pps->id); - if (err) + if (IS_ERR(pps->dev)) goto del_cdev; dev_set_drvdata(pps->dev, pps); |