summaryrefslogtreecommitdiffstats
path: root/drivers/ptp
diff options
context:
space:
mode:
authorYang Yingliang <yangyingliang@huawei.com>2020-04-24 14:52:26 +0200
committerDavid S. Miller <davem@davemloft.net>2020-04-26 05:41:42 +0200
commit3e14462f1bee6d74eea6425d7965357d55151f80 (patch)
treeb4f47ef32607b0dead6abc9ffbcb6e84f5e034a1 /drivers/ptp
parenthsr: remove unnecessary code in hsr_dev_change_mtu() (diff)
downloadlinux-3e14462f1bee6d74eea6425d7965357d55151f80.tar.xz
linux-3e14462f1bee6d74eea6425d7965357d55151f80.zip
ptp: clockmatrix: remove unnecessary comparison
The type of loaddr is u8 which is always '<=' 0xff, so the loaddr <= 0xff is always true, we can remove this comparison. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Reviewed-by: Vincent Cheng <vincent.cheng.xh@renesas.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/ptp')
-rw-r--r--drivers/ptp/ptp_clockmatrix.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/ptp/ptp_clockmatrix.c b/drivers/ptp/ptp_clockmatrix.c
index 032e112c3dd9..a3f608832660 100644
--- a/drivers/ptp/ptp_clockmatrix.c
+++ b/drivers/ptp/ptp_clockmatrix.c
@@ -780,7 +780,7 @@ static int idtcm_load_firmware(struct idtcm *idtcm,
/* Page size 128, last 4 bytes of page skipped */
if (((loaddr > 0x7b) && (loaddr <= 0x7f))
- || ((loaddr > 0xfb) && (loaddr <= 0xff)))
+ || loaddr > 0xfb)
continue;
err = idtcm_write(idtcm, regaddr, 0, &val, sizeof(val));