diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2020-02-10 22:22:39 +0100 |
|---|---|---|
| committer | Thierry Reding <thierry.reding@gmail.com> | 2020-03-30 16:55:25 +0200 |
| commit | 4563654fddc05a572f889373ba22abc616b3aa1f (patch) | |
| tree | 77820daca6dfcf597d715a6da914719fde492490 /drivers/pwm/pwm-imx27.c | |
| parent | pwm: imx27: Simplify helper function to enable and disable clocks (diff) | |
| download | linux-4563654fddc05a572f889373ba22abc616b3aa1f.tar.xz linux-4563654fddc05a572f889373ba22abc616b3aa1f.zip | |
pwm: imx27: Don't disable clocks at device remove time
The .remove() callback is not supposed to modify hardware state. This is
in the responsibility of the PWM consumer.
After the PWM was disabled the clocks are off (apart from a bug that is
fixed in the next patch), so unbinding the driver either stops the PWM
(which it should not) or disables already disabled clocks yielding
warnings from the clk core.
So just drop the call to disable the clocks. (Which BTW was also in the
wrong order because the call makes the PWM unfunctional and so should
have come only after pwmchip_remove()).
Fixes: 9f4c8f9607c3 ("pwm: imx: Add ipg clock operation")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
Diffstat (limited to 'drivers/pwm/pwm-imx27.c')
| -rw-r--r-- | drivers/pwm/pwm-imx27.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/pwm/pwm-imx27.c b/drivers/pwm/pwm-imx27.c index e04ae566bbf9..fb142813d455 100644 --- a/drivers/pwm/pwm-imx27.c +++ b/drivers/pwm/pwm-imx27.c @@ -358,8 +358,6 @@ static int pwm_imx27_remove(struct platform_device *pdev) imx = platform_get_drvdata(pdev); - pwm_imx27_clk_disable_unprepare(imx); - return pwmchip_remove(&imx->chip); } |