diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2021-03-26 09:18:04 +0100 |
|---|---|---|
| committer | Thierry Reding <thierry.reding@gmail.com> | 2021-04-09 14:44:12 +0200 |
| commit | 819e82460ac858cdca38f748829979602a7708ee (patch) | |
| tree | d4d62915d8549d74a018ba2e9082b2cedff23c66 /drivers/pwm | |
| parent | pwm: bcm2835: Free resources only after pwmchip_remove() (diff) | |
| download | linux-819e82460ac858cdca38f748829979602a7708ee.tar.xz linux-819e82460ac858cdca38f748829979602a7708ee.zip | |
pwm: bcm-kona: Don't modify HW state in .remove callback
A consumer is expected to disable a PWM before calling pwm_put(). And if
they didn't there is hopefully a good reason (or the consumer needs
fixing.) Also if disabling an enabled PWM was the right thing to do, this
should better be done in the framework instead of in each low level driver.
So drop the hardware modification from the .remove() callback.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
Diffstat (limited to 'drivers/pwm')
| -rw-r--r-- | drivers/pwm/pwm-bcm-kona.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/drivers/pwm/pwm-bcm-kona.c b/drivers/pwm/pwm-bcm-kona.c index f09a31042859..800b9edf2e71 100644 --- a/drivers/pwm/pwm-bcm-kona.c +++ b/drivers/pwm/pwm-bcm-kona.c @@ -310,11 +310,6 @@ static int kona_pwmc_probe(struct platform_device *pdev) static int kona_pwmc_remove(struct platform_device *pdev) { struct kona_pwmc *kp = platform_get_drvdata(pdev); - unsigned int chan; - - for (chan = 0; chan < kp->chip.npwm; chan++) - if (pwm_is_enabled(&kp->chip.pwms[chan])) - clk_disable_unprepare(kp->clk); return pwmchip_remove(&kp->chip); } |