diff options
author | Atsushi Nemoto <anemo@mba.ocn.ne.jp> | 2012-08-22 01:16:10 +0200 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2012-08-22 01:45:03 +0200 |
commit | 7dbfb315b2aaef0a115765946bf3026d074c33a7 (patch) | |
tree | c3fe42971fbd713a1bc7bc263410a4eaec8521fc /drivers/rapidio | |
parent | mm: correct page->pfmemalloc to fix deactivate_slab regression (diff) | |
download | linux-7dbfb315b2aaef0a115765946bf3026d074c33a7.tar.xz linux-7dbfb315b2aaef0a115765946bf3026d074c33a7.zip |
drivers/rtc/rtc-rs5c348.c: fix hour decoding in 12-hour mode
Correct the offset by subtracting 20 from tm_hour before taking the
modulo 12.
[ "Why 20?" I hear you ask. Or at least I did.
Here's the reason why: RS5C348_BIT_PM is 32, and is - stupidly -
included in the RS5C348_HOURS_MASK define. So it's really subtracting
out that bit to get "hour+12". But then because it does things modulo
12, it needs to add the 12 in again afterwards anyway.
This code is confused. It would be much clearer if RS5C348_HOURS_MASK
just didn't include the RS5C348_BIT_PM bit at all, then it wouldn't
need to do the silly subtract either.
Whatever. It's all just math, the end result is the same. - Linus ]
Reported-by: James Nute <newten82@gmail.com>
Tested-by: James Nute <newten82@gmail.com>
Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/rapidio')
0 files changed, 0 insertions, 0 deletions