diff options
| author | Charles Keepax <ckeepax@opensource.wolfsonmicro.com> | 2015-02-20 17:08:44 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2015-02-21 15:30:30 +0100 |
| commit | a7b976ae4bff9ff4f9c9943d3232dec7e87c68b9 (patch) | |
| tree | 823648d45b3f9a161f6135bd63a984321e233668 /drivers/regulator/arizona-micsupp.c | |
| parent | Linux 3.19 (diff) | |
| download | linux-a7b976ae4bff9ff4f9c9943d3232dec7e87c68b9.tar.xz linux-a7b976ae4bff9ff4f9c9943d3232dec7e87c68b9.zip | |
regulator: arizona-micsupp: Drop OF node reference on error path
We were not calling of_node_put if the regulator failed to register this
patch fixes this.
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/regulator/arizona-micsupp.c')
| -rw-r--r-- | drivers/regulator/arizona-micsupp.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/regulator/arizona-micsupp.c b/drivers/regulator/arizona-micsupp.c index 20079006459a..4116e74effa4 100644 --- a/drivers/regulator/arizona-micsupp.c +++ b/drivers/regulator/arizona-micsupp.c @@ -284,6 +284,9 @@ static int arizona_micsupp_probe(struct platform_device *pdev) micsupp->regulator = devm_regulator_register(&pdev->dev, desc, &config); + + of_node_put(config.of_node); + if (IS_ERR(micsupp->regulator)) { ret = PTR_ERR(micsupp->regulator); dev_err(arizona->dev, "Failed to register mic supply: %d\n", @@ -291,8 +294,6 @@ static int arizona_micsupp_probe(struct platform_device *pdev) return ret; } - of_node_put(config.of_node); - platform_set_drvdata(pdev, micsupp); return 0; |