diff options
| author | Steve Twiss <stwiss.opensource@diasemi.com> | 2019-02-26 15:59:59 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2019-03-13 16:09:58 +0100 |
| commit | 5e6afb3832bedf420dd8e4c5b32ed85117c5087d (patch) | |
| tree | eca3fa61e4a71f60ae4b04d0aea8d4970e5bd433 /drivers/regulator/da9055-regulator.c | |
| parent | regulator: gpio: Constify regulator_ops (diff) | |
| download | linux-5e6afb3832bedf420dd8e4c5b32ed85117c5087d.tar.xz linux-5e6afb3832bedf420dd8e4c5b32ed85117c5087d.zip | |
regulator: da9055: Fix notifier mutex lock warning
The mutex for the regulator_dev must be controlled by the caller of
the regulator_notifier_call_chain(), as described in the comment
for that function.
Failure to mutex lock and unlock surrounding the notifier call results
in a kernel WARN_ON_ONCE() which will dump a backtrace for the
regulator_notifier_call_chain() when that function call is first made.
The mutex can be controlled using the regulator_lock/unlock() API.
Fixes: f6130be652d0 ("regulator: DA9055 regulator driver")
Suggested-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/regulator/da9055-regulator.c')
| -rw-r--r-- | drivers/regulator/da9055-regulator.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/regulator/da9055-regulator.c b/drivers/regulator/da9055-regulator.c index 3c6fac793658..3ade4b8d204e 100644 --- a/drivers/regulator/da9055-regulator.c +++ b/drivers/regulator/da9055-regulator.c @@ -487,8 +487,10 @@ static irqreturn_t da9055_ldo5_6_oc_irq(int irq, void *data) { struct da9055_regulator *regulator = data; + regulator_lock(regulator->rdev); regulator_notifier_call_chain(regulator->rdev, REGULATOR_EVENT_OVER_CURRENT, NULL); + regulator_unlock(regulator->rdev); return IRQ_HANDLED; } |