diff options
| author | Sachin Kamat <sachin.kamat@linaro.org> | 2014-02-18 11:41:04 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@linaro.org> | 2014-02-19 17:30:08 +0100 |
| commit | 145fe1e1d533943fc93da42d6f2e13aba919776e (patch) | |
| tree | 613756bf3315371f03c4d94fc1ebd45444bf0712 /drivers/regulator/fan53555.c | |
| parent | Linus 3.14-rc1 (diff) | |
| download | linux-145fe1e1d533943fc93da42d6f2e13aba919776e.tar.xz linux-145fe1e1d533943fc93da42d6f2e13aba919776e.zip | |
regulator: fan53555: Do not hardcode return values
Propagate the error values returned by the function instead.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Mark Brown <broonie@linaro.org>
Diffstat (limited to 'drivers/regulator/fan53555.c')
| -rw-r--r-- | drivers/regulator/fan53555.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/regulator/fan53555.c b/drivers/regulator/fan53555.c index 7ca3d9e3b0fe..a10df7d150cc 100644 --- a/drivers/regulator/fan53555.c +++ b/drivers/regulator/fan53555.c @@ -90,11 +90,11 @@ static int fan53555_set_suspend_voltage(struct regulator_dev *rdev, int uV) return 0; ret = regulator_map_voltage_linear(rdev, uV, uV); if (ret < 0) - return -EINVAL; + return ret; ret = regmap_update_bits(di->regmap, di->sleep_reg, VSEL_NSEL_MASK, ret); if (ret < 0) - return -EINVAL; + return ret; /* Cache the sleep voltage setting. * Might not be the real voltage which is rounded */ di->sleep_vol_cache = uV; @@ -260,14 +260,14 @@ static int fan53555_regulator_probe(struct i2c_client *client, ret = regmap_read(di->regmap, FAN53555_ID1, &val); if (ret < 0) { dev_err(&client->dev, "Failed to get chip ID!\n"); - return -ENODEV; + return ret; } di->chip_id = val & DIE_ID; /* Get chip revision */ ret = regmap_read(di->regmap, FAN53555_ID2, &val); if (ret < 0) { dev_err(&client->dev, "Failed to get chip Rev!\n"); - return -ENODEV; + return ret; } di->chip_rev = val & DIE_REV; dev_info(&client->dev, "FAN53555 Option[%d] Rev[%d] Detected!\n", |