diff options
| author | Axel Lin <axel.lin@gmail.com> | 2010-08-09 11:01:21 +0200 |
|---|---|---|
| committer | Liam Girdwood <lrg@slimlogic.co.uk> | 2010-08-11 12:38:02 +0200 |
| commit | 1bddc2f5c1727577183761581d5d4d1b00a8bd63 (patch) | |
| tree | d0c7817f6ad349ce4f12f638c0e09cbb2dfcb365 /drivers/regulator/lp3971.c | |
| parent | regulator: max8660 - fix a memory leak in max8660_remove() (diff) | |
| download | linux-1bddc2f5c1727577183761581d5d4d1b00a8bd63.tar.xz linux-1bddc2f5c1727577183761581d5d4d1b00a8bd63.zip | |
regulator: lp3971 - remove unnecessary ret value checking in lp3971_i2c_write()
i2c_smbus_write_byte_data() returns zero or negative value,
therefore no need to check if ret is greater than zero or not.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Liam Girdwood <lrg@slimlogic.co.uk>
Diffstat (limited to 'drivers/regulator/lp3971.c')
| -rw-r--r-- | drivers/regulator/lp3971.c | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/drivers/regulator/lp3971.c b/drivers/regulator/lp3971.c index 5362289c7d69..3bb82b624e19 100644 --- a/drivers/regulator/lp3971.c +++ b/drivers/regulator/lp3971.c @@ -387,15 +387,9 @@ static int lp3971_i2c_read(struct i2c_client *i2c, char reg, int count, static int lp3971_i2c_write(struct i2c_client *i2c, char reg, int count, const u16 *src) { - int ret; - if (count != 1) return -EIO; - ret = i2c_smbus_write_byte_data(i2c, reg, *src); - if (ret >= 0) - return 0; - - return ret; + return i2c_smbus_write_byte_data(i2c, reg, *src); } static u8 lp3971_reg_read(struct lp3971 *lp3971, u8 reg) |