diff options
| author | Kangjie Lu <kjlu@umn.edu> | 2018-12-19 06:04:13 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2018-12-19 13:37:52 +0100 |
| commit | 966e927bf8cc6a44f8b72582a1d6d3ffc73b12ad (patch) | |
| tree | ca43c6c5bf5f25abc61cbd98f59ce734a3401ad2 /drivers/regulator | |
| parent | regulator: act8945a-regulator: fix 'defined but not used' compiler warning (diff) | |
| download | linux-966e927bf8cc6a44f8b72582a1d6d3ffc73b12ad.tar.xz linux-966e927bf8cc6a44f8b72582a1d6d3ffc73b12ad.zip | |
drivers/regulator: fix a missing check of return value
If palmas_smps_read() fails, we should not use the read data in "reg"
which may contain random value. The fix inserts a check for the return
value of palmas_smps_read(): If it fails, we return the error code
upstream and stop using "reg".
Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/regulator')
| -rw-r--r-- | drivers/regulator/palmas-regulator.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/regulator/palmas-regulator.c b/drivers/regulator/palmas-regulator.c index bb5ab7d78895..c2cc392a27d4 100644 --- a/drivers/regulator/palmas-regulator.c +++ b/drivers/regulator/palmas-regulator.c @@ -443,13 +443,16 @@ static int palmas_ldo_write(struct palmas *palmas, unsigned int reg, static int palmas_set_mode_smps(struct regulator_dev *dev, unsigned int mode) { int id = rdev_get_id(dev); + int ret; struct palmas_pmic *pmic = rdev_get_drvdata(dev); struct palmas_pmic_driver_data *ddata = pmic->palmas->pmic_ddata; struct palmas_regs_info *rinfo = &ddata->palmas_regs_info[id]; unsigned int reg; bool rail_enable = true; - palmas_smps_read(pmic->palmas, rinfo->ctrl_addr, ®); + ret = palmas_smps_read(pmic->palmas, rinfo->ctrl_addr, ®); + if (ret) + return ret; reg &= ~PALMAS_SMPS12_CTRL_MODE_ACTIVE_MASK; |