diff options
| author | Colin Ian King <colin.king@canonical.com> | 2017-09-03 15:06:01 +0200 |
|---|---|---|
| committer | Bjorn Andersson <bjorn.andersson@linaro.org> | 2017-09-04 19:52:30 +0200 |
| commit | ed43d098f9020d6669a00bd26fac807d5c19e202 (patch) | |
| tree | 90d5f0f36172a3922136152f440952e014b1e90b /drivers/remoteproc | |
| parent | rpmsg: glink: fix null pointer dereference on a null intent (diff) | |
| download | linux-ed43d098f9020d6669a00bd26fac807d5c19e202.tar.xz linux-ed43d098f9020d6669a00bd26fac807d5c19e202.zip | |
rpmsg: glink: initialize ret to zero to ensure error status check is correct
The new switch cases for RPM_CMD_RX_DONE, RPM_CMD_RX_DONE_W_REUSE,
RPM_CMD_RX_INTENT_REQ_ACK, RPM_CMD_INTENT and RPM_CMD_RX_INTENT_REQ from
4 recent commits are not setting ret and so a later non-zero check on ret
is testing on a garbage value in ret. Fix this by initializing ret to zero.
Detected by CoverityScan CID#1455249 ("Uninitialized scalar variable")
Fixes: 933b45da5d1d ("rpmsg: glink: Add support for TX intents)
Fixes: dacbb35e930f ("glink: Receive and store the remote intent buffers")
Fixes: 27b9c5b66b23 ("rpmsg: glink: Request for intents when unavailable")
Fixes: 88c6060f5a7f ("rpmsg: glink: Handle remote rx done command")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Diffstat (limited to 'drivers/remoteproc')
0 files changed, 0 insertions, 0 deletions