diff options
author | Jun Chen <jun.d.chen@intel.com> | 2012-10-22 16:23:07 +0200 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-10-25 20:29:58 +0200 |
commit | c73ba2ae43fd4d69589caeecc5260a41be87b759 (patch) | |
tree | 1cb25c6cf3d0eb3010e8e24c1e1531ad4569431e /drivers/rtc/interface.c | |
parent | serial: ifx6x60: different SPI word width configure requires different swap p... (diff) | |
download | linux-c73ba2ae43fd4d69589caeecc5260a41be87b759.tar.xz linux-c73ba2ae43fd4d69589caeecc5260a41be87b759.zip |
serial: ifx6x60: add_timer is not safe in the mrdy_assert function
This patch make use of mod_timer instead of add_timer in the mrdy_assert function.
Because the srdy interrupter can go high when we are running function mrdy_assert and mrdy_assert
can be called by multi-entry. In our medfield platform, spi stress test can encounter this
error logs triggered by the BUG_ON of add_timer function.This patch had been tested on
our medfield platform.
the scenario:
CPU0 CPU1
mrdy_assert
set_bit(IFX_SPI_STATE_TIMER_PENDING)
ifx_spi_handle_srdy
...
clear_bit(IFX_SPI_STATE_TIMER_PENDING)
...
mrdy_assert
set_bit(IFX_SPI_STATE_TIMER_PENDING)
...
add_timer
...
add_timer
Cc: liu chuansheng <chuansheng.liu@intel.com>
Cc: Bi Chao <chao.bi@intel.com>
Signed-off-by: Chen Jun <jun.d.chen@intel.com>
Acked-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/rtc/interface.c')
0 files changed, 0 insertions, 0 deletions