diff options
| author | Alexandre Belloni <alexandre.belloni@bootlin.com> | 2020-10-15 21:11:33 +0200 |
|---|---|---|
| committer | Alexandre Belloni <alexandre.belloni@bootlin.com> | 2020-10-19 22:48:55 +0200 |
| commit | 8b34134907e7d70b8b51fa56ecd4f8c50c46692c (patch) | |
| tree | 57a64302d18919402b7afad86f2c58db059738c8 /drivers/rtc/rtc-r9701.c | |
| parent | rtc: r9701: remove useless memset (diff) | |
| download | linux-8b34134907e7d70b8b51fa56ecd4f8c50c46692c.tar.xz linux-8b34134907e7d70b8b51fa56ecd4f8c50c46692c.zip | |
rtc: r9701: stop setting RWKCNT
tm_wday is never checked for validity and it is not read back in
r9701_get_datetime. Avoid setting it to stop tripping static checkers:
drivers/rtc/rtc-r9701.c:109 r9701_set_datetime()
error: undefined (user controlled) shift '1 << dt->tm_wday'
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20201015191135.471249-4-alexandre.belloni@bootlin.com
Diffstat (limited to '')
| -rw-r--r-- | drivers/rtc/rtc-r9701.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/rtc/rtc-r9701.c b/drivers/rtc/rtc-r9701.c index 4b688e9c4192..183c5a0fe78c 100644 --- a/drivers/rtc/rtc-r9701.c +++ b/drivers/rtc/rtc-r9701.c @@ -100,7 +100,6 @@ static int r9701_set_datetime(struct device *dev, struct rtc_time *dt) ret = ret ? ret : write_reg(dev, RDAYCNT, bin2bcd(dt->tm_mday)); ret = ret ? ret : write_reg(dev, RMONCNT, bin2bcd(dt->tm_mon + 1)); ret = ret ? ret : write_reg(dev, RYRCNT, bin2bcd(dt->tm_year - 100)); - ret = ret ? ret : write_reg(dev, RWKCNT, 1 << dt->tm_wday); return ret; } |