summaryrefslogtreecommitdiffstats
path: root/drivers/rtc
diff options
context:
space:
mode:
authorSachin Kamat <sachin.kamat@linaro.org>2013-11-13 00:10:26 +0100
committerLinus Torvalds <torvalds@linux-foundation.org>2013-11-13 04:09:27 +0100
commitc91fd91d686654f8afbbbca18f5ff0a6ebc9c7a2 (patch)
tree4b0c363fe12b653afd9eabd426dedb816801a23d /drivers/rtc
parentdrivers/rtc/rtc-ds1307.c: release irq on error (diff)
downloadlinux-c91fd91d686654f8afbbbca18f5ff0a6ebc9c7a2.tar.xz
linux-c91fd91d686654f8afbbbca18f5ff0a6ebc9c7a2.zip
drivers/rtc/rtc-isl1208.c: remove redundant checks
i2c_smbus_read_byte_data() returns negative errno on failure. Return the value obtained from it directly. Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> Cc: Herbert Valerio Riedel <hvr@gnu.org> Cc: Jingoo Han <jg1.han@samsung.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/rtc')
-rw-r--r--drivers/rtc/rtc-isl1208.c6
1 files changed, 1 insertions, 5 deletions
diff --git a/drivers/rtc/rtc-isl1208.c b/drivers/rtc/rtc-isl1208.c
index c016ad81767a..5a0bf7ce1033 100644
--- a/drivers/rtc/rtc-isl1208.c
+++ b/drivers/rtc/rtc-isl1208.c
@@ -144,11 +144,7 @@ isl1208_i2c_validate_client(struct i2c_client *client)
static int
isl1208_i2c_get_sr(struct i2c_client *client)
{
- int sr = i2c_smbus_read_byte_data(client, ISL1208_REG_SR);
- if (sr < 0)
- return -EIO;
-
- return sr;
+ return i2c_smbus_read_byte_data(client, ISL1208_REG_SR);
}
static int