diff options
| author | Alexandre Belloni <alexandre.belloni@bootlin.com> | 2019-12-14 23:02:56 +0100 |
|---|---|---|
| committer | Alexandre Belloni <alexandre.belloni@bootlin.com> | 2019-12-18 10:37:40 +0100 |
| commit | 7e890a0f0e4d777d8292539a0609d3aeef6e6da4 (patch) | |
| tree | 5441ba8d7154e82f47f0fca97521c6b50b496873 /drivers/rtc | |
| parent | rtc: rv3028: return meaningful value for RTC_VL_READ (diff) | |
| download | linux-7e890a0f0e4d777d8292539a0609d3aeef6e6da4.tar.xz linux-7e890a0f0e4d777d8292539a0609d3aeef6e6da4.zip | |
rtc: rv8803: avoid clearing RV8803_FLAG_V2F in RTC_VL_CLR
Stop clearing RV8803_FLAG_V2F in RTC_VL_CLR because it is a disservice to
userspace as it removes the important information that the RTC data is
invalid. This may lead userspace to set an invalid system time later on.
Link: https://lore.kernel.org/r/20191214220259.621996-15-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Diffstat (limited to 'drivers/rtc')
| -rw-r--r-- | drivers/rtc/rtc-rv8803.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/rtc/rtc-rv8803.c b/drivers/rtc/rtc-rv8803.c index 4960f0a2b249..ed92116bdfa0 100644 --- a/drivers/rtc/rtc-rv8803.c +++ b/drivers/rtc/rtc-rv8803.c @@ -440,7 +440,7 @@ static int rv8803_ioctl(struct device *dev, unsigned int cmd, unsigned long arg) return flags; } - flags &= ~(RV8803_FLAG_V1F | RV8803_FLAG_V2F); + flags &= ~RV8803_FLAG_V1F; ret = rv8803_write_reg(client, RV8803_FLAG, flags); mutex_unlock(&rv8803->flags_lock); if (ret) |