diff options
| author | Christian Borntraeger <borntraeger@de.ibm.com> | 2008-12-25 13:38:34 +0100 |
|---|---|---|
| committer | Martin Schwidefsky <schwidefsky@de.ibm.com> | 2008-12-25 13:38:54 +0100 |
| commit | a114a9d69d1362546b9dda651028acb311ddb7af (patch) | |
| tree | c538cbdb79ca97bd06d889d62300f0fbf53c3c6a /drivers/s390/char | |
| parent | [S390] cpu topology: dont destroy cpu sets on topology change (diff) | |
| download | linux-a114a9d69d1362546b9dda651028acb311ddb7af.tar.xz linux-a114a9d69d1362546b9dda651028acb311ddb7af.zip | |
[S390] vmcp: remove BKL
The vmcp driver uses the session->mutex for concurrent access of the data
structures. Therefore, the BKL in vmcp_open does not protect against any
other function in the driver.
The BLK in vmcp_open would protect concurrent access to the module init
but all necessary steps ave finished before misc_register is called.
We can safely remove the lock_kernel from vcmp.
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Diffstat (limited to 'drivers/s390/char')
| -rw-r--r-- | drivers/s390/char/vmcp.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/s390/char/vmcp.c b/drivers/s390/char/vmcp.c index 09e7d9bf438b..d7083b33b0fe 100644 --- a/drivers/s390/char/vmcp.c +++ b/drivers/s390/char/vmcp.c @@ -16,7 +16,6 @@ #include <linux/kernel.h> #include <linux/miscdevice.h> #include <linux/module.h> -#include <linux/smp_lock.h> #include <asm/cpcmd.h> #include <asm/debug.h> #include <asm/uaccess.h> @@ -41,13 +40,11 @@ static int vmcp_open(struct inode *inode, struct file *file) if (!session) return -ENOMEM; - lock_kernel(); session->bufsize = PAGE_SIZE; session->response = NULL; session->resp_size = 0; mutex_init(&session->mutex); file->private_data = session; - unlock_kernel(); return nonseekable_open(inode, file); } |