diff options
| author | Julian Wiedmann <jwi@linux.ibm.com> | 2020-05-07 10:21:53 +0200 |
|---|---|---|
| committer | Vasily Gorbik <gor@linux.ibm.com> | 2020-05-28 12:21:55 +0200 |
| commit | cafebf8653b3d689b3411daa0d3d7b67fc4f2edb (patch) | |
| tree | 5487ba65ac17d0ca4eea3438e0c026f5e95b7e44 /drivers/s390/cio/qdio.h | |
| parent | s390/qdio: fix up qdio_start_irq() kerneldoc (diff) | |
| download | linux-cafebf8653b3d689b3411daa0d3d7b67fc4f2edb.tar.xz linux-cafebf8653b3d689b3411daa0d3d7b67fc4f2edb.zip | |
s390/qdio: remove q->first_to_kick
q->first_to_kick is obsolete, and can be replaced by q->first_to_check.
Both cursors start off at 0. Out of the three code paths that update
first_to_check, the qdio_inspect_queue() path is irrelevant as it
doesn't even touch first_to_kick anymore.
This leaves us with the two tasklet-driven code paths. Here any update
to first_to_check is followed by a call to qdio_kick_handler(), which
advances first_to_kick by the same amount.
So the two cursors will differ only for a tiny moment. Drivers have no
way of deterministically observing this difference, and thus it doesn't
matter which of the cursors we use for reporting an error to q->handler.
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
Diffstat (limited to 'drivers/s390/cio/qdio.h')
| -rw-r--r-- | drivers/s390/cio/qdio.h | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/s390/cio/qdio.h b/drivers/s390/cio/qdio.h index 66191e864b0b..eb13c479e11d 100644 --- a/drivers/s390/cio/qdio.h +++ b/drivers/s390/cio/qdio.h @@ -221,9 +221,6 @@ struct qdio_q { */ int first_to_check; - /* beginning position for calling the program */ - int first_to_kick; - /* number of buffers in use by the adapter */ atomic_t nr_buf_used; |